Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APM] Charts: Disable showing values on series labels #127646

Merged
merged 1 commit into from
Mar 16, 2022
Merged

[APM] Charts: Disable showing values on series labels #127646

merged 1 commit into from
Mar 16, 2022

Conversation

younesmln
Copy link
Contributor

Closes #121405.

Before

2022-03-14 19 31 54

After

2022-03-14 19 28 53

@younesmln younesmln requested a review from a team as a code owner March 14, 2022 18:43
@younesmln younesmln linked an issue Mar 14, 2022 that may be closed by this pull request
[APM] Charts: Disable showing values on series labels #121405
Closed
@botelastic botelastic bot added the Team:APM All issues that need APM UI Team support label Mar 14, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@younesmln younesmln added v8.2.0 release_note:skip Skip the PR/issue when compiling release notes labels Mar 14, 2022
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 2.8MB 2.8MB -19.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

sorenlouv
sorenlouv approved these changes Mar 14, 2022
View reviewed changes
Copy link
Member

@sorenlouv sorenlouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, that was easy! :D

@formgeist
Copy link
Contributor

"Good first issue" - thanks for picking this up @younesmln 🙌

@younesmln younesmln merged commit ade7177 into main Mar 16, 2022
@younesmln younesmln deleted the 121405-apm-charts-disable-showing-values-on-series-labels branch March 16, 2022 12:42
maksimkovalev pushed a commit to maksimkovalev/kibana that referenced this pull request Mar 18, 2022
@younesmln @maksimkovalev
[APM] Charts: Disable showing values on series labels (elastic#127646)
97a1c75
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Mar 18, 2022
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 127646 or prevent reminders by adding the backport:skip label.

1 similar comment
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 127646 or prevent reminders by adding the backport:skip label.

@MiriamAparicio
Copy link
Contributor

@younesmln you can add the backport:skip label, the 8.2 branch it's not created yet, will be everything that is in main

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 127646 or prevent reminders by adding the backport:skip label.

2 similar comments
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 127646 or prevent reminders by adding the backport:skip label.

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 127646 or prevent reminders by adding the backport:skip label.

@gbamparop gbamparop added the backport:skip This commit does not require backporting label Mar 24, 2022
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Mar 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sorenlouv sorenlouv sorenlouv approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:APM All issues that need APM UI Team support v8.2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[APM] Charts: Disable showing values on series labels
8 participants
@younesmln @elasticmachine @kibana-ci @formgeist @kibanamachine @MiriamAparicio @sorenlouv @gbamparop